c30461cc92
CI / Rust Checks (pull_request) Successful in 6m4s
CI / UI Checks (pull_request) Successful in 5s
CI / Community Image Smoke (pull_request) Successful in 4m27s
CI / Frontend E2E (pull_request) Successful in 5m19s
CI / Deploy (pull_request) Has been skipped
CI / Rust Checks (push) Successful in 6m5s
CI / UI Checks (push) Successful in 5s
CI / Community Image Smoke (push) Successful in 1m5s
CI / Frontend E2E (push) Successful in 3m54s
CI / Deploy (push) Failing after 45s
242 lines
7.4 KiB
Rust
242 lines
7.4 KiB
Rust
use std::{
|
|
io,
|
|
sync::{Arc, Mutex},
|
|
};
|
|
|
|
use admin_api::request_context::{REQUEST_ID_HEADER, apply_request_context};
|
|
use axum::{
|
|
Router,
|
|
body::Body,
|
|
http::{HeaderMap, HeaderValue, Request, StatusCode},
|
|
routing::get,
|
|
};
|
|
use crank_observability::{
|
|
ObservabilityConfig, RedactionLimits, ServiceIdentity, inject_current_trace_context,
|
|
};
|
|
use opentelemetry::{global, trace::TracerProvider as _};
|
|
use opentelemetry_sdk::{propagation::TraceContextPropagator, trace::SdkTracerProvider};
|
|
use tower::ServiceExt;
|
|
use tracing_subscriber::{fmt::MakeWriter, layer::SubscriberExt};
|
|
use uuid::Version;
|
|
|
|
static TRACING_TEST_LOCK: tokio::sync::Mutex<()> = tokio::sync::Mutex::const_new(());
|
|
|
|
#[tokio::test(flavor = "current_thread")]
|
|
async fn logs_request_completion_and_rejects_untrusted_values() {
|
|
let _tracing_test_guard = TRACING_TEST_LOCK.lock().await;
|
|
let writer = SharedLogWriter::default();
|
|
let subscriber = crank_observability::build_subscriber(
|
|
ObservabilityConfig::new(
|
|
ServiceIdentity::try_new("admin-api", "test", "test").unwrap(),
|
|
"info",
|
|
RedactionLimits::default(),
|
|
),
|
|
writer.clone(),
|
|
)
|
|
.unwrap();
|
|
let dispatch = tracing::Dispatch::new(subscriber);
|
|
let _dispatch_guard = tracing::dispatcher::set_default(&dispatch);
|
|
let app = probe_app();
|
|
|
|
let response = app
|
|
.clone()
|
|
.oneshot(
|
|
Request::builder()
|
|
.uri("/probe")
|
|
.header(REQUEST_ID_HEADER.as_str(), "req_admin_trace_123")
|
|
.body(Body::empty())
|
|
.unwrap(),
|
|
)
|
|
.await
|
|
.unwrap();
|
|
|
|
assert_eq!(response.status(), StatusCode::OK);
|
|
assert_eq!(
|
|
response.headers()[REQUEST_ID_HEADER.as_str()]
|
|
.to_str()
|
|
.unwrap(),
|
|
"req_admin_trace_123"
|
|
);
|
|
let event: serde_json::Value = writer
|
|
.output()
|
|
.lines()
|
|
.map(|line| serde_json::from_str(line).unwrap())
|
|
.find(|event: &serde_json::Value| event["event"] == "admin.request.completed")
|
|
.unwrap();
|
|
assert_eq!(event["request_id"], "req_admin_trace_123");
|
|
assert_eq!(event["fields"]["status"], 200);
|
|
assert_eq!(event["fields"]["route"], "/probe");
|
|
|
|
let invalid_response = app
|
|
.oneshot(
|
|
Request::builder()
|
|
.uri("/probe")
|
|
.header(REQUEST_ID_HEADER.as_str(), "bad,value")
|
|
.header("traceparent", "canary-invalid-traceparent")
|
|
.body(Body::empty())
|
|
.unwrap(),
|
|
)
|
|
.await
|
|
.unwrap();
|
|
let generated = invalid_response.headers()[REQUEST_ID_HEADER.as_str()]
|
|
.to_str()
|
|
.unwrap();
|
|
assert_eq!(
|
|
uuid::Uuid::parse_str(generated).unwrap().get_version(),
|
|
Some(Version::SortRand)
|
|
);
|
|
assert!(!writer.output().contains("canary-invalid-traceparent"));
|
|
}
|
|
|
|
#[tokio::test(flavor = "current_thread")]
|
|
async fn covers_valid_invalid_and_absent_traceparent() {
|
|
let _tracing_test_guard = TRACING_TEST_LOCK.lock().await;
|
|
global::set_text_map_propagator(TraceContextPropagator::new());
|
|
let provider = SdkTracerProvider::builder().build();
|
|
let tracer = provider.tracer("admin-request-context-test");
|
|
let subscriber =
|
|
tracing_subscriber::registry().with(tracing_opentelemetry::layer().with_tracer(tracer));
|
|
let dispatch = tracing::Dispatch::new(subscriber);
|
|
let _dispatch_guard = tracing::dispatcher::set_default(&dispatch);
|
|
let app = trace_probe_app();
|
|
|
|
let valid = observed_trace_id(
|
|
app.clone()
|
|
.oneshot(
|
|
Request::builder()
|
|
.uri("/trace")
|
|
.header(
|
|
"traceparent",
|
|
"00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01",
|
|
)
|
|
.header(REQUEST_ID_HEADER.as_str(), "request-id-is-separate")
|
|
.body(Body::empty())
|
|
.unwrap(),
|
|
)
|
|
.await
|
|
.unwrap(),
|
|
);
|
|
let invalid = observed_trace_id(
|
|
app.clone()
|
|
.oneshot(
|
|
Request::builder()
|
|
.uri("/trace")
|
|
.header("traceparent", "canary-invalid-traceparent")
|
|
.body(Body::empty())
|
|
.unwrap(),
|
|
)
|
|
.await
|
|
.unwrap(),
|
|
);
|
|
let absent = observed_trace_id(
|
|
app.oneshot(
|
|
Request::builder()
|
|
.uri("/trace")
|
|
.body(Body::empty())
|
|
.unwrap(),
|
|
)
|
|
.await
|
|
.unwrap(),
|
|
);
|
|
|
|
assert_eq!(valid, "0af7651916cd43dd8448eb211c80319c");
|
|
assert_ne!(invalid, valid);
|
|
assert_ne!(absent, valid);
|
|
assert_ne!(invalid, absent);
|
|
provider.shutdown().unwrap();
|
|
}
|
|
|
|
#[tokio::test(flavor = "current_thread")]
|
|
async fn replaces_multiple_request_id_headers_with_one_uuid_v7() {
|
|
let _tracing_test_guard = TRACING_TEST_LOCK.lock().await;
|
|
let dispatch = tracing::Dispatch::new(tracing_subscriber::registry());
|
|
let _dispatch_guard = tracing::dispatcher::set_default(&dispatch);
|
|
let mut request = Request::builder()
|
|
.uri("/probe")
|
|
.body(Body::empty())
|
|
.unwrap();
|
|
request.headers_mut().append(
|
|
REQUEST_ID_HEADER,
|
|
HeaderValue::from_static("first-request-id"),
|
|
);
|
|
request.headers_mut().append(
|
|
REQUEST_ID_HEADER,
|
|
HeaderValue::from_static("second-request-id"),
|
|
);
|
|
|
|
let response = probe_app().oneshot(request).await.unwrap();
|
|
let generated = response.headers()[REQUEST_ID_HEADER].to_str().unwrap();
|
|
|
|
assert_ne!(generated, "first-request-id");
|
|
assert_ne!(generated, "second-request-id");
|
|
assert_eq!(
|
|
uuid::Uuid::parse_str(generated).unwrap().get_version(),
|
|
Some(Version::SortRand)
|
|
);
|
|
}
|
|
|
|
fn probe_app() -> Router {
|
|
Router::new()
|
|
.route("/probe", get(|| async { "ok" }))
|
|
.layer(axum::middleware::from_fn(apply_request_context))
|
|
}
|
|
|
|
fn trace_probe_app() -> Router {
|
|
Router::new()
|
|
.route("/trace", get(observed_traceparent))
|
|
.layer(axum::middleware::from_fn(apply_request_context))
|
|
}
|
|
|
|
async fn observed_traceparent() -> HeaderMap {
|
|
let mut trace_headers = HeaderMap::new();
|
|
inject_current_trace_context(&mut trace_headers);
|
|
let mut response_headers = HeaderMap::new();
|
|
if let Some(traceparent) = trace_headers.remove("traceparent") {
|
|
response_headers.insert("x-observed-traceparent", traceparent);
|
|
}
|
|
response_headers
|
|
}
|
|
|
|
fn observed_trace_id(response: axum::response::Response) -> String {
|
|
let traceparent = response.headers()["x-observed-traceparent"]
|
|
.to_str()
|
|
.unwrap();
|
|
traceparent[3..35].to_owned()
|
|
}
|
|
|
|
#[derive(Clone, Default)]
|
|
struct SharedLogWriter {
|
|
buffer: Arc<Mutex<Vec<u8>>>,
|
|
}
|
|
|
|
impl SharedLogWriter {
|
|
fn output(&self) -> String {
|
|
String::from_utf8(self.buffer.lock().unwrap().clone()).unwrap()
|
|
}
|
|
}
|
|
|
|
impl<'a> MakeWriter<'a> for SharedLogWriter {
|
|
type Writer = SharedLogGuard;
|
|
|
|
fn make_writer(&'a self) -> Self::Writer {
|
|
SharedLogGuard {
|
|
buffer: Arc::clone(&self.buffer),
|
|
}
|
|
}
|
|
}
|
|
|
|
struct SharedLogGuard {
|
|
buffer: Arc<Mutex<Vec<u8>>>,
|
|
}
|
|
|
|
impl io::Write for SharedLogGuard {
|
|
fn write(&mut self, bytes: &[u8]) -> io::Result<usize> {
|
|
self.buffer.lock().unwrap().extend_from_slice(bytes);
|
|
Ok(bytes.len())
|
|
}
|
|
|
|
fn flush(&mut self) -> io::Result<()> {
|
|
Ok(())
|
|
}
|
|
}
|