CI / Rust Checks (pull_request) Failing after 13m41s
CI / UI Checks (pull_request) Skipped
CI / Frontend E2E (pull_request) Skipped
CI / Community Image Smoke (pull_request) Skipped
CI / Deploy (pull_request) Skipped
Community Release / release (push) Failing after 13m33s
Recovery delivery of the accumulated, TL-accepted Epic 3 work that had never been
committed to Git (stories 3.6-3.17, see the crank board). Story 3.18 is not accepted
yet and is deliberately excluded: its logging surface, its capability registration,
its oracle projections and its tests are not part of this tree.
Accepted scope
- 3.6 typed static Resource Drafts; 3.7 publication and exact binding of static
Resource Versions; 3.8 MCP discovery/read and revocation of static Resources;
- 3.9 Resource import/export in API and UI plus TLS dependency maintenance;
3.10 REST-backed Resource templates; 3.11 shared REST read runtime and the MCP
revision/capability foundation;
- 3.12 parameterised Prompt Drafts with preview; 3.13 Prompt publication and exact
version binding to Agents; 3.14 MCP prompts; 3.15 Prompt import/export;
- 3.16 composite Prompts with published Resources (dependency content scan plus
dynamic read through the accepted 3.11 runtime, admin preview and MCP prompts/get);
- 3.17 bounded MCP completion suggestions from typed published schemas and the
resources/list admission fix for bound template publications.
Accepted evidence being reused (unchanged code paths)
- 3.16 candidate: core 7, admin-api 22, registry 4, mcp-server 4, UI 6; one final
`just verify` run 1651 passed / 0 failed / 2 ignored.
- 3.17 candidate: full run 1672 passed / 0 failed / 2 ignored, QA targeted reruns and
a real MCP Inspector 2.12.0 client smoke.
Delivery engineering in this commit
- CI: one event per change (feature branches are gated by their pull request, push
runs only on main), story events run the changed packages, the full workspace suite
stays the feature/release gate; no cache/sharding without a measured runner check.
- Release: the packaged archives, checksums and SBOM are now uploaded to the Gitea
release entry of the tag instead of dying with the runner workspace.
Not included on purpose: Story 3.18 work, build caches, runtime databases, local
credentials and scratch evidence.
Refs: crank kanban t_e39d7263; baseline 1b6db09bd1.
152 lines
5.5 KiB
Rust
152 lines
5.5 KiB
Rust
//! UNIT Story 3.10 (FR-16): typed source contract и single-sourced policy bounds.
|
||
//!
|
||
//! Build-only шов: тип определения шаблона существует только с этим build, поэтому
|
||
//! HTTP-уровень проверяется отдельно (`admin-api`/`template*.rs`), а здесь —
|
||
//! serde-контракт (unknown fields denied, exact operation version обязателен) и
|
||
//! exported cache/failure пределы, которыми пользуются validator и API.
|
||
|
||
use crank_core::resource::template::{
|
||
MAX_TEMPLATE_CACHE_BYTES, MAX_TEMPLATE_CACHE_TTL_MS, TEMPLATE_CACHE_SCOPE, TemplateCache,
|
||
TemplateFindingCode, TemplateSource, cache_policy_findings,
|
||
};
|
||
use serde_json::{Value, json};
|
||
use std::collections::BTreeSet;
|
||
|
||
fn source_value() -> Value {
|
||
json!({
|
||
"operation_id": "op_story310",
|
||
"operation_version": 1,
|
||
"uri_template": "crank://orders/{order_id}",
|
||
"parameters": [{
|
||
"name": "order_id",
|
||
"input_path": "input.order_id",
|
||
"schema": { "type": "string", "required": true, "format": "uuid" }
|
||
}],
|
||
"cache": { "ttl_ms": 60000, "vary": ["order_id"], "max_bytes": 65536 },
|
||
"failure": { "outcome": "error" }
|
||
})
|
||
}
|
||
|
||
#[test]
|
||
fn story310_at01_source_contract_denies_unknown_fields_and_draft_state() {
|
||
let parsed = TemplateSource::parse(&source_value()).expect("typed source must parse");
|
||
assert_eq!(parsed.operation_id, "op_story310");
|
||
assert_eq!(parsed.operation_version, 1);
|
||
assert_eq!(parsed.parameters[0].input_path, "input.order_id");
|
||
|
||
// Arbitrary URL/inline request definition не представимы: любой неизвестный
|
||
// ключ на любом уровне — структурный отказ.
|
||
for (path, value) in [
|
||
(vec!["url"], json!("https://evil.example/orders")),
|
||
(vec!["request"], json!({ "url": "https://evil.example" })),
|
||
(vec!["method"], json!("POST")),
|
||
(
|
||
vec!["parameters", "0", "url"],
|
||
json!("https://evil.example"),
|
||
),
|
||
(vec!["cache", "scope"], json!("workspace")),
|
||
] {
|
||
let mut source = source_value();
|
||
let mut cursor = &mut source;
|
||
for step in &path[..path.len() - 1] {
|
||
cursor = match step.parse::<usize>() {
|
||
Ok(index) => &mut cursor[index],
|
||
Err(_) => &mut cursor[*step],
|
||
};
|
||
}
|
||
cursor[path[path.len() - 1]] = value;
|
||
assert!(
|
||
TemplateSource::parse(&source).is_err(),
|
||
"unknown field must be denied: {path:?}"
|
||
);
|
||
}
|
||
|
||
// «latest alias»/Draft state не выражаются: версия обязательна и явная.
|
||
let mut without_version = source_value();
|
||
without_version
|
||
.as_object_mut()
|
||
.expect("object")
|
||
.remove("operation_version");
|
||
assert!(TemplateSource::parse(&without_version).is_err());
|
||
|
||
let mut latest = source_value();
|
||
latest["operation_version"] = json!("latest");
|
||
assert!(TemplateSource::parse(&latest).is_err());
|
||
}
|
||
|
||
#[test]
|
||
fn story310_at04_policy_bounds_are_single_sourced() {
|
||
assert_eq!(MAX_TEMPLATE_CACHE_TTL_MS, 86_400_000);
|
||
assert_eq!(MAX_TEMPLATE_CACHE_BYTES, 262_144);
|
||
assert_eq!(TEMPLATE_CACHE_SCOPE, "workspace_agent_auth");
|
||
|
||
let names: BTreeSet<&str> = ["order_id"].into_iter().collect();
|
||
let cache = |ttl_ms: u64, vary: Vec<&str>, max_bytes: u64| TemplateCache {
|
||
ttl_ms,
|
||
vary: vary.into_iter().map(str::to_owned).collect(),
|
||
max_bytes,
|
||
};
|
||
|
||
// Значения ровно на границе принимаются.
|
||
assert!(
|
||
cache_policy_findings(
|
||
&cache(
|
||
MAX_TEMPLATE_CACHE_TTL_MS,
|
||
vec!["order_id"],
|
||
MAX_TEMPLATE_CACHE_BYTES
|
||
),
|
||
&names
|
||
)
|
||
.is_empty()
|
||
);
|
||
|
||
// MAX+1 и 0 — те же exported границы, что использует публикация.
|
||
for (ttl_ms, max_bytes, expected) in [
|
||
(
|
||
MAX_TEMPLATE_CACHE_TTL_MS + 1,
|
||
MAX_TEMPLATE_CACHE_BYTES,
|
||
TemplateFindingCode::CacheTtlInvalid,
|
||
),
|
||
(
|
||
0,
|
||
MAX_TEMPLATE_CACHE_BYTES,
|
||
TemplateFindingCode::CacheTtlInvalid,
|
||
),
|
||
(
|
||
MAX_TEMPLATE_CACHE_TTL_MS,
|
||
MAX_TEMPLATE_CACHE_BYTES + 1,
|
||
TemplateFindingCode::CacheSizeInvalid,
|
||
),
|
||
(
|
||
MAX_TEMPLATE_CACHE_TTL_MS,
|
||
0,
|
||
TemplateFindingCode::CacheSizeInvalid,
|
||
),
|
||
] {
|
||
let findings = cache_policy_findings(&cache(ttl_ms, vec!["order_id"], max_bytes), &names);
|
||
assert!(
|
||
findings.iter().any(|finding| finding.code == expected),
|
||
"expected {expected:?} for ttl={ttl_ms} bytes={max_bytes}: {findings:?}"
|
||
);
|
||
}
|
||
|
||
// vary: чужое имя, повтор и пропуск объявленного параметра.
|
||
for (vary, expected) in [
|
||
(
|
||
vec!["order_id", "tenant_id"],
|
||
TemplateFindingCode::VaryUnknown,
|
||
),
|
||
(
|
||
vec!["order_id", "order_id"],
|
||
TemplateFindingCode::VaryDuplicate,
|
||
),
|
||
(vec![], TemplateFindingCode::VaryIncomplete),
|
||
] {
|
||
let findings = cache_policy_findings(&cache(60_000, vary, 65_536), &names);
|
||
assert!(
|
||
findings.iter().any(|finding| finding.code == expected),
|
||
"expected {expected:?}: {findings:?}"
|
||
);
|
||
}
|
||
}
|