CI / Rust Checks (pull_request) Failing after 13m41s
CI / UI Checks (pull_request) Skipped
CI / Frontend E2E (pull_request) Skipped
CI / Community Image Smoke (pull_request) Skipped
CI / Deploy (pull_request) Skipped
Community Release / release (push) Failing after 13m33s
Recovery delivery of the accumulated, TL-accepted Epic 3 work that had never been
committed to Git (stories 3.6-3.17, see the crank board). Story 3.18 is not accepted
yet and is deliberately excluded: its logging surface, its capability registration,
its oracle projections and its tests are not part of this tree.
Accepted scope
- 3.6 typed static Resource Drafts; 3.7 publication and exact binding of static
Resource Versions; 3.8 MCP discovery/read and revocation of static Resources;
- 3.9 Resource import/export in API and UI plus TLS dependency maintenance;
3.10 REST-backed Resource templates; 3.11 shared REST read runtime and the MCP
revision/capability foundation;
- 3.12 parameterised Prompt Drafts with preview; 3.13 Prompt publication and exact
version binding to Agents; 3.14 MCP prompts; 3.15 Prompt import/export;
- 3.16 composite Prompts with published Resources (dependency content scan plus
dynamic read through the accepted 3.11 runtime, admin preview and MCP prompts/get);
- 3.17 bounded MCP completion suggestions from typed published schemas and the
resources/list admission fix for bound template publications.
Accepted evidence being reused (unchanged code paths)
- 3.16 candidate: core 7, admin-api 22, registry 4, mcp-server 4, UI 6; one final
`just verify` run 1651 passed / 0 failed / 2 ignored.
- 3.17 candidate: full run 1672 passed / 0 failed / 2 ignored, QA targeted reruns and
a real MCP Inspector 2.12.0 client smoke.
Delivery engineering in this commit
- CI: one event per change (feature branches are gated by their pull request, push
runs only on main), story events run the changed packages, the full workspace suite
stays the feature/release gate; no cache/sharding without a measured runner check.
- Release: the packaged archives, checksums and SBOM are now uploaded to the Gitea
release entry of the tag instead of dying with the runner workspace.
Not included on purpose: Story 3.18 work, build caches, runtime databases, local
credentials and scratch evidence.
Refs: crank kanban t_e39d7263; baseline 1b6db09bd1.
94 lines
4.1 KiB
Rust
94 lines
4.1 KiB
Rust
//! Preview-снимок Resource: metadata, безопасные findings и инертный `text` (D-6, AC01).
|
||
//!
|
||
//! Вынесено из `service/resources.rs` ради health-лимита 1000 строк: preview —
|
||
//! единственный второй читатель pinned-снимка, и его findings обязаны считаться теми
|
||
//! же validators/scanner, что и публикация.
|
||
|
||
use super::*;
|
||
|
||
impl ResourcesService {
|
||
/// Preview: метаданные + findings + инертный `text` только для text/json (D-6).
|
||
///
|
||
/// Metadata и bytes относятся к **одному** разрешению версии: второй запрос за
|
||
/// card-строкой смешал бы metadata версии N с bytes версии N+1 при одновременном
|
||
/// обновлении (P3, TL F05).
|
||
pub(crate) async fn preview(
|
||
&self,
|
||
workspace_id: &WorkspaceId,
|
||
resource_id: &ResourceId,
|
||
) -> Result<ResourcePreviewResponse, ResourceError> {
|
||
// Story 3.10: template Draft не имеет bytes — preview отдаёт findings и text=null,
|
||
// не обращаясь ни к artifact store, ни к REST.
|
||
let record = self
|
||
.registry
|
||
.get_resource_draft(workspace_id.as_str(), resource_id)
|
||
.await?;
|
||
if record.version.source_kind == "template" {
|
||
let (source, findings) = self
|
||
.template_card(workspace_id, resource_id, record.version.version)
|
||
.await?;
|
||
let card = ResourceCardResponse::from_record(&record);
|
||
return Ok(ResourcePreviewResponse {
|
||
resource: card.resource,
|
||
version: card.version,
|
||
findings,
|
||
preview: ResourcePreviewView { text: None },
|
||
source: Some(source),
|
||
});
|
||
}
|
||
let (bytes, resolved) = self.load_content(workspace_id, resource_id).await?;
|
||
let card = ResourceCardResponse::from_record(&resolved.snapshot);
|
||
let kind = card.kind()?;
|
||
let text = match kind {
|
||
ResourceKind::Text | ResourceKind::Json => Some(
|
||
String::from_utf8(bytes.clone()).map_err(|_| ResourceError::ContentInvalidUtf8)?,
|
||
),
|
||
// Для binary bytes не возвращаются вообще.
|
||
ResourceKind::Binary => None,
|
||
};
|
||
let findings = self
|
||
.preview_findings(workspace_id, &card, kind, &bytes)
|
||
.await?;
|
||
Ok(ResourcePreviewResponse {
|
||
resource: card.resource,
|
||
version: card.version,
|
||
findings,
|
||
preview: ResourcePreviewView { text },
|
||
source: None,
|
||
})
|
||
}
|
||
|
||
/// Findings preview (AC01): те же validators/scanner, что и у публикации, на тех же
|
||
/// pinned bytes. Наружу уходят только стабильные `code`/`field`; bytes содержимого,
|
||
/// совпавший фрагмент и цель `include:` никогда не попадают в ответ.
|
||
async fn preview_findings(
|
||
&self,
|
||
workspace_id: &WorkspaceId,
|
||
card: &ResourceCardResponse,
|
||
kind: ResourceKind,
|
||
bytes: &[u8],
|
||
) -> Result<Vec<PreviewFinding>, ResourceError> {
|
||
let mut findings = Vec::new();
|
||
let metadata = ResourceMetadata {
|
||
uri: card.resource.uri.clone(),
|
||
name: card.resource.name.clone(),
|
||
description: card.resource.description.clone(),
|
||
kind,
|
||
mime_type: card.version.mime_type.clone(),
|
||
sensitivity: parse_sensitivity(&card.version.sensitivity)?,
|
||
};
|
||
if let Err(error) =
|
||
ResourceMetadata::validate_content(kind, &metadata.mime_type, bytes, &self.limits)
|
||
{
|
||
findings.push(PreviewFinding::from_error(&error));
|
||
}
|
||
for error in self
|
||
.publication_findings(workspace_id, &metadata, bytes)
|
||
.await?
|
||
{
|
||
findings.push(PreviewFinding::from_error(&error));
|
||
}
|
||
Ok(findings)
|
||
}
|
||
}
|