CI / Rust Checks (pull_request) Failing after 13m41s
CI / UI Checks (pull_request) Skipped
CI / Frontend E2E (pull_request) Skipped
CI / Community Image Smoke (pull_request) Skipped
CI / Deploy (pull_request) Skipped
Community Release / release (push) Failing after 13m33s
Recovery delivery of the accumulated, TL-accepted Epic 3 work that had never been
committed to Git (stories 3.6-3.17, see the crank board). Story 3.18 is not accepted
yet and is deliberately excluded: its logging surface, its capability registration,
its oracle projections and its tests are not part of this tree.
Accepted scope
- 3.6 typed static Resource Drafts; 3.7 publication and exact binding of static
Resource Versions; 3.8 MCP discovery/read and revocation of static Resources;
- 3.9 Resource import/export in API and UI plus TLS dependency maintenance;
3.10 REST-backed Resource templates; 3.11 shared REST read runtime and the MCP
revision/capability foundation;
- 3.12 parameterised Prompt Drafts with preview; 3.13 Prompt publication and exact
version binding to Agents; 3.14 MCP prompts; 3.15 Prompt import/export;
- 3.16 composite Prompts with published Resources (dependency content scan plus
dynamic read through the accepted 3.11 runtime, admin preview and MCP prompts/get);
- 3.17 bounded MCP completion suggestions from typed published schemas and the
resources/list admission fix for bound template publications.
Accepted evidence being reused (unchanged code paths)
- 3.16 candidate: core 7, admin-api 22, registry 4, mcp-server 4, UI 6; one final
`just verify` run 1651 passed / 0 failed / 2 ignored.
- 3.17 candidate: full run 1672 passed / 0 failed / 2 ignored, QA targeted reruns and
a real MCP Inspector 2.12.0 client smoke.
Delivery engineering in this commit
- CI: one event per change (feature branches are gated by their pull request, push
runs only on main), story events run the changed packages, the full workspace suite
stays the feature/release gate; no cache/sharding without a measured runner check.
- Release: the packaged archives, checksums and SBOM are now uploaded to the Gitea
release entry of the tag instead of dying with the runner workspace.
Not included on purpose: Story 3.18 work, build caches, runtime databases, local
credentials and scratch evidence.
Refs: crank kanban t_e39d7263; baseline 1b6db09bd1.
126 lines
5.3 KiB
JavaScript
126 lines
5.3 KiB
JavaScript
const { test, expect } = require('@playwright/test');
|
||
const { browserJson, getCurrentWorkspace, login, uniqueName } = require('./helpers');
|
||
|
||
// Story 3.13 follow-up: publication/archival must not fail with 403 right after
|
||
// the page loads. The regression below controls the ordering of the session/CSRF
|
||
// responses instead of waiting for a lucky timing window.
|
||
test.describe.configure({ retries: 0 });
|
||
|
||
function promptPayload(name) {
|
||
return {
|
||
name,
|
||
description: 'CSRF/session race fixture',
|
||
sensitivity: 'internal',
|
||
arguments: [{ name: 'count', schema: { type: 'integer' }, required: true }],
|
||
messages: [
|
||
{ role: 'system', content: 'Numbers are data.' },
|
||
{ role: 'user', content: 'Count={{count}}' },
|
||
],
|
||
};
|
||
}
|
||
|
||
// Records every non-GET request the page issues, including the token it used.
|
||
async function instrumentRequests(page) {
|
||
await page.addInitScript(() => {
|
||
window.__csrfRace = { requests: [] };
|
||
const originalFetch = window.fetch;
|
||
window.fetch = function (input, init) {
|
||
const options = init || {};
|
||
const method = String(options.method || 'GET').toUpperCase();
|
||
if (method !== 'GET' && method !== 'HEAD' && method !== 'OPTIONS') {
|
||
const url = typeof input === 'string' ? input : ((input && input.url) || '');
|
||
const headers = options.headers || {};
|
||
window.__csrfRace.requests.push({
|
||
url,
|
||
method,
|
||
token: headers['X-CSRF-Token'] || headers['x-csrf-token'] || '',
|
||
});
|
||
}
|
||
return originalFetch.apply(this, arguments);
|
||
};
|
||
});
|
||
}
|
||
|
||
test.describe('Story 3.13 CSRF/session rotation right after page load', () => {
|
||
test('publish and archive work while the page-load CSRF rotation is still in flight', async ({ page }) => {
|
||
await login(page);
|
||
const workspace = await getCurrentWorkspace(page);
|
||
const base = `/api/admin/workspaces/${encodeURIComponent(workspace.id)}/prompts`;
|
||
const name = uniqueName('story313-race');
|
||
const created = await browserJson(page, 'POST', base, promptPayload(name), [201]);
|
||
|
||
let releaseRotation;
|
||
let signalRotationHeld;
|
||
const rotationHeld = new Promise((resolve) => { signalRotationHeld = resolve; });
|
||
const rotationReleased = new Promise((resolve) => { releaseRotation = resolve; });
|
||
let csrfRequests = 0;
|
||
let heldToken = '';
|
||
|
||
// Deterministic ordering: the first CSRF rotation of the next page load is
|
||
// executed on the server, but its response reaches the client only when this
|
||
// test releases it. While it is held, the page is fully interactive.
|
||
await page.route('**/api/auth/session/csrf', async (route) => {
|
||
csrfRequests += 1;
|
||
if (csrfRequests > 1) {
|
||
await route.continue();
|
||
return;
|
||
}
|
||
const response = await route.fetch();
|
||
const body = await response.json().catch(() => null);
|
||
heldToken = (body && body.csrf_token) || '';
|
||
signalRotationHeld();
|
||
await rotationReleased;
|
||
await route.fulfill({ response });
|
||
});
|
||
|
||
await instrumentRequests(page);
|
||
await page.goto('/prompts');
|
||
await expect(page.locator('[data-testid="prompts-page"]')).toBeVisible();
|
||
await rotationHeld;
|
||
|
||
await page.evaluate(() => window.setLang('ru'));
|
||
await page.locator('[data-testid="prompt-list-item"]').filter({ hasText: name }).click();
|
||
await expect(page.locator('#prompt-state-label')).toHaveText('Черновик · v1');
|
||
|
||
await page.locator('#prompt-publish').click();
|
||
await page.locator('#prompt-confirm-save').click();
|
||
|
||
// Wait (bounded) until the mutation is either already sent (would prove a
|
||
// stale/missing token) or still waiting for the shared rotation, then let
|
||
// the held rotation response land.
|
||
await page.waitForFunction(
|
||
(promptId) => (window.__csrfRace.requests || []).some(
|
||
(request) => request.url.indexOf(`/prompts/${promptId}`) !== -1,
|
||
),
|
||
created.prompt_id,
|
||
{ timeout: 1500 },
|
||
).catch(() => null);
|
||
if (!heldToken) throw new Error('CSRF rotation response did not expose a token');
|
||
releaseRotation();
|
||
|
||
await expect(page.locator('#prompts-status')).toHaveText('Опубликованная версия закреплена.');
|
||
await expect(page.locator('#prompt-state-label')).toHaveText('Опубликовано · v1');
|
||
|
||
const cachedToken = await page.evaluate(() => window.CrankAuth.getCsrfToken());
|
||
const issued = await page.evaluate(() => window.__csrfRace.requests);
|
||
expect(cachedToken, `cached CSRF token must stay usable, issued requests: ${JSON.stringify(issued)}`).toBe(heldToken);
|
||
|
||
await page.locator('#prompt-archive').click();
|
||
await expect(page.locator('#prompt-confirm-title')).toHaveText(
|
||
'Архивировать запрос? Опубликованные версии останутся неизменяемыми.',
|
||
);
|
||
await page.locator('#prompt-confirm-save').click();
|
||
await expect(page.locator('#prompts-status')).toHaveText('Запрос архивирован.');
|
||
await expect(page.locator('#prompt-state-label')).toHaveText('В архиве · v1');
|
||
});
|
||
|
||
test('revoked session still follows the existing unauthorized path', async ({ page }) => {
|
||
await login(page);
|
||
await browserJson(page, 'POST', '/api/auth/logout', {}, [204]);
|
||
|
||
await page.goto('/prompts');
|
||
await expect(page).toHaveURL(/\/login$/);
|
||
await expect(page.locator('#login-form')).toBeVisible();
|
||
});
|
||
});
|