story 2-10-security-schemes-secrets: implemented and reviewed via bmad-loop

This commit is contained in:
bsodfather committed 2026-10-03 00:09:08 +03:00
1 parent f5f40cb167
commit ecfb4e788f
45 files changed
+6025 -829

No files matched your search

@@ -14,6 +14,115 @@ mod http_contract;
mod import_plan_apply;
mod import_plan_create;
#[tokio::test]
#[serial]
async fn upload_rejects_credential_literals_before_persisting_source_artifacts() {
let registry = test_registry().await;
let storage_root = test_storage_root("openapi_import_storage_redaction");
let service = test_service(
registry.clone(),
storage_root,
test_auth_settings(),
test_secret_crypto(),
);
let workspace_id = WorkspaceId::new("ws_default");
let upload = OpenApiUpload {
bytes: br#"{
"openapi":"3.0.3",
"info":{"title":"Redaction persistence","version":"1"},
"servers":[{"url":"https://bare-canary@api.example.test/v1?api_key=query-canary"}],
"components":{"securitySchemes":{"key":{"type":"apiKey","in":"header","name":"X-Api-Key"}}},
"paths":{"/private":{"get":{
"operationId":"privateOperation",
"parameters":[{"name":"X-Api-Key","in":"header","example":"opaque-canary-42"}],
"responses":{"200":{"description":"ok"}},
"x-client-secret":true
}}}
}"#
.to_vec(),
mime_type: "application/json".to_owned(),
locale: OpenApiUploadLocale::En,
};
let error = service
.preview_openapi_import(&workspace_id, upload)
.await
.expect_err("credential-bearing uploads must be rejected before persistence");
let rendered_error = format!("{error:?}");
assert!(
rendered_error.contains("invalid_document"),
"unexpected typed error: {rendered_error}"
);
for canary in ["bare-canary", "query-canary", "opaque-canary-42"] {
assert!(
!rendered_error.contains(canary),
"API error leaked {canary}"
);
}
let source_count: i64 =
sqlx::query_scalar("select count(*) from artifact_sources where workspace_id = $1")
.bind(workspace_id.as_str())
.fetch_one(registry.pool())
.await
.unwrap();
assert_eq!(source_count, 0, "unsafe upload created an artifact source");
}
#[tokio::test]
#[serial]
async fn legacy_apply_rejects_required_auth_without_binding_before_creating_draft() {
let registry = test_registry().await;
let service = test_service(
registry.clone(),
test_storage_root("openapi_import_unresolved_auth"),
test_auth_settings(),
test_secret_crypto(),
);
let workspace_id = WorkspaceId::new("ws_default");
let upload = OpenApiUpload {
bytes: br#"{
"openapi":"3.0.3",
"info":{"title":"Required auth","version":"1"},
"servers":[{"url":"https://api.example.test"}],
"components":{"securitySchemes":{"bearer":{"type":"http","scheme":"bearer"}}},
"security":[{"bearer":[]}],
"paths":{"/secure":{"get":{"operationId":"secureOperation","responses":{"200":{"description":"ok"}}}}}
}"#
.to_vec(),
mime_type: "application/json".to_owned(),
locale: OpenApiUploadLocale::En,
};
let preview = service
.preview_openapi_import(&workspace_id, upload)
.await
.unwrap();
let result = service
.create_openapi_import(
&workspace_id,
&preview.job_id.as_str().into(),
OpenApiImportCreatePayload {
selected_operation_keys: vec!["GET /secure".to_owned()],
server_url: None,
conflict_mode: "rename".to_owned(),
},
)
.await;
let error = result.expect_err("legacy apply cannot bypass unresolved required auth");
assert!(format!("{error:?}").contains("invalid_document"));
assert!(
service
.list_operations(&workspace_id)
.await
.unwrap()
.is_empty()
);
let job = registry
.get_import_job(&workspace_id, &preview.job_id.as_str().into())
.await
.unwrap()
.unwrap();
assert_eq!(job.status, ImportJobStatus::Failed);
}
const OPENAPI3: &str = r#"
openapi: 3.0.3
info:
@@ -80,11 +189,11 @@ async fn previews_openapi_and_creates_draft_operations() {
assert_eq!(preview_job.status, ImportJobStatus::Pending);
assert_eq!(
preview_job.preview_payload["normalization"]["normalizer_version"],
"normalized-ir-v4"
crank_import::rest::NORMALIZER_VERSION
);
assert_eq!(
preview_job.preview_payload["normalization"]["projection_version"],
"preview-v4"
crank_import::rest::PROJECTION_VERSION
);
assert!(preview_job.preview_payload["normalization"]["ir_fingerprint"].is_string());