fix: harden typed metrics review findings
This commit is contained in:
1 parent
996a5461de
commit
b7face0e94
30 files changed
+722
-382
No files matched your search
@@ -261,7 +261,15 @@ impl RuntimeExecutor {
|
||||
let invocation_metrics = ToolInvocationMetrics::start_with_exemplar(
|
||||
metric_invocation_source(request_context),
|
||||
request_context.and_then(|context| {
|
||||
crank_metrics::ExemplarTraceId::parse(&context.trace_context.trace_id().to_string())
|
||||
context
|
||||
.trace_context
|
||||
.is_sampled()
|
||||
.then(|| {
|
||||
crank_metrics::ExemplarTraceId::parse(
|
||||
&context.trace_context.trace_id().to_string(),
|
||||
)
|
||||
})
|
||||
.flatten()
|
||||
}),
|
||||
);
|
||||
let result = async {
|
||||
|
||||
Reference in new issue
Block a user