cache: define response cache boundaries

2026-05-03 22:22:16 +00:00
parent d3b7d246da
commit 851d70ad7a
9 changed files with 234 additions and 19 deletions
@@ -240,9 +240,9 @@ mod tests {
    use crank_core::{
        AsyncJobHandle, AsyncJobId, DescriptorId, ExecutionConfig, ExecutionMode,
        GraphqlOperationType, GraphqlTarget, GrpcTarget, HttpMethod, JobStatus, MembershipRole,
-        OperationId, OperationSecurityLevel, Protocol, RestTarget, SecretKind, SoapBindingStyle,
-        SoapOperationMetadata, SoapTarget, SoapVersion, StreamSession, StreamStatus, Target,
-        ToolDescription, TransportBehavior, WebsocketTarget, WorkspaceId,
+        OperationId, OperationSecurityLevel, Protocol, ResponseCachePolicy, RestTarget, SecretKind,
+        SoapBindingStyle, SoapOperationMetadata, SoapTarget, SoapVersion, StreamSession,
+        StreamStatus, Target, ToolDescription, TransportBehavior, WebsocketTarget, WorkspaceId,
    };
    use crank_mapping::{MappingRule, MappingSet};
    use crank_registry::{CreateAsyncJobRequest, CreateStreamSessionRequest, PostgresRegistry};
@@ -1362,6 +1362,71 @@ mod tests {
        );
    }

+    #[tokio::test(flavor = "multi_thread")]
+    #[serial]
+    async fn rejects_response_cache_for_non_get_rest_operation_create() {
+        let registry = test_registry().await;
+        let storage_root = test_storage_root("community_response_cache_post_reject");
+        let upstream_base_url = spawn_upstream_server().await;
+        let base_url = spawn_admin_api(build_test_app(registry, storage_root)).await;
+        let client = authorized_client(&base_url).await;
+
+        let mut payload = test_operation_payload(&upstream_base_url, "crm_cache_post");
+        payload.execution_config.response_cache = Some(ResponseCachePolicy { ttl_ms: 5_000 });
+
+        let response = client
+            .post(format!("{base_url}/operations"))
+            .json(&payload)
+            .send()
+            .await
+            .unwrap();
+        let status = response.status();
+        let body = response.json::<Value>().await.unwrap();
+
+        assert_eq!(status, reqwest::StatusCode::BAD_REQUEST);
+        assert_eq!(body["error"]["code"], "validation_error");
+        assert_eq!(
+            body["error"]["context"]["field"],
+            "execution_config.response_cache"
+        );
+    }
+
+    #[tokio::test(flavor = "multi_thread")]
+    #[serial]
+    async fn rejects_response_cache_for_operation_with_auth_profile() {
+        let registry = test_registry().await;
+        let storage_root = test_storage_root("community_response_cache_auth_reject");
+        let upstream_base_url = spawn_upstream_server().await;
+        let base_url = spawn_admin_api(build_test_app(registry, storage_root)).await;
+        let client = authorized_client(&base_url).await;
+
+        let mut payload = test_operation_payload(&upstream_base_url, "crm_cache_auth");
+        payload.target = Target::Rest(RestTarget {
+            base_url: upstream_base_url,
+            method: HttpMethod::Get,
+            path_template: "/crm/leads".to_owned(),
+            static_headers: BTreeMap::new(),
+        });
+        payload.execution_config.response_cache = Some(ResponseCachePolicy { ttl_ms: 5_000 });
+        payload.execution_config.auth_profile_ref = Some("auth_profile_01".into());
+
+        let response = client
+            .post(format!("{base_url}/operations"))
+            .json(&payload)
+            .send()
+            .await
+            .unwrap();
+        let status = response.status();
+        let body = response.json::<Value>().await.unwrap();
+
+        assert_eq!(status, reqwest::StatusCode::BAD_REQUEST);
+        assert_eq!(body["error"]["code"], "validation_error");
+        assert_eq!(
+            body["error"]["context"]["field"],
+            "execution_config.auth_profile_ref"
+        );
+    }
+
    #[tokio::test(flavor = "multi_thread")]
    #[serial]
    async fn manages_workspace_access_lifecycle() {
@@ -3455,6 +3520,7 @@ mod tests {
            execution_config: ExecutionConfig {
                timeout_ms: 1_000,
                retry_policy: None,
+                response_cache: None,
                auth_profile_ref: None,
                headers: BTreeMap::new(),
                protocol_options: None,
@@ -3512,6 +3578,7 @@ mod tests {
            execution_config: ExecutionConfig {
                timeout_ms: 1_000,
                retry_policy: None,
+                response_cache: None,
                auth_profile_ref: None,
                headers: BTreeMap::new(),
                protocol_options: None,
@@ -3568,6 +3635,7 @@ mod tests {
            execution_config: ExecutionConfig {
                timeout_ms: 1_000,
                retry_policy: None,
+                response_cache: None,
                auth_profile_ref: None,
                headers: BTreeMap::new(),
                protocol_options: None,
@@ -3725,6 +3793,7 @@ mod tests {
            execution_config: ExecutionConfig {
                timeout_ms: 1_000,
                retry_policy: None,
+                response_cache: None,
                auth_profile_ref: None,
                headers: BTreeMap::new(),
                protocol_options: None,
@@ -3780,6 +3849,7 @@ mod tests {
            execution_config: ExecutionConfig {
                timeout_ms: 1_000,
                retry_policy: None,
+                response_cache: None,
                auth_profile_ref: None,
                headers: BTreeMap::new(),
                protocol_options: None,