api: add structured context for read path errors

2026-04-19 21:50:28 +00:00
parent ba10bf805d
commit 84555aaf70
2 changed files with 108 additions and 14 deletions
@@ -499,7 +499,16 @@ mod tests {
            .send()
            .await
            .unwrap();
-        assert_eq!(missing.status(), reqwest::StatusCode::NOT_FOUND);
+        let missing_status = missing.status();
+        let missing = missing.json::<Value>().await.unwrap();
+        assert_eq!(missing_status, reqwest::StatusCode::NOT_FOUND);
+        assert_eq!(missing["error"]["code"], "not_found");
+        assert_eq!(
+            missing["error"]["context"],
+            json!({
+                "operation_id": operation_id
+            })
+        );
    }

    #[tokio::test(flavor = "multi_thread")]
@@ -708,7 +717,16 @@ mod tests {
            .send()
            .await
            .unwrap();
-        assert_eq!(missing.status(), reqwest::StatusCode::NOT_FOUND);
+        let missing_status = missing.status();
+        let missing = missing.json::<Value>().await.unwrap();
+        assert_eq!(missing_status, reqwest::StatusCode::NOT_FOUND);
+        assert_eq!(missing["error"]["code"], "not_found");
+        assert_eq!(
+            missing["error"]["context"],
+            json!({
+                "agent_id": agent_id
+            })
+        );
    }

    #[tokio::test(flavor = "multi_thread")]
@@ -1945,6 +1963,58 @@ mod tests {
        assert_eq!(deleted["ok"], true);
        assert_eq!(missing_status, reqwest::StatusCode::NOT_FOUND);
        assert_eq!(missing["error"]["code"], "not_found");
+        assert_eq!(
+            missing["error"]["context"],
+            json!({
+                "secret_id": secret_id
+            })
+        );
+    }
+
+    #[tokio::test(flavor = "multi_thread")]
+    #[serial]
+    async fn returns_structured_context_for_missing_operation_version() {
+        let registry = test_registry().await;
+        let storage_root = test_storage_root("missing_operation_version");
+        let upstream_base_url = spawn_upstream_server().await;
+        let base_url = spawn_admin_api(build_test_app(registry, storage_root)).await;
+        let client = authorized_client(&base_url).await;
+
+        let created = client
+            .post(format!("{base_url}/operations"))
+            .json(&test_operation_payload(
+                &upstream_base_url,
+                "crm_missing_operation_version",
+            ))
+            .send()
+            .await
+            .unwrap()
+            .json::<Value>()
+            .await
+            .unwrap();
+        let operation_id = created["operation_id"].as_str().unwrap().to_owned();
+
+        let response = client
+            .get(format!("{base_url}/operations/{operation_id}/versions/99"))
+            .send()
+            .await
+            .unwrap();
+        let status = response.status();
+        let body = response.json::<Value>().await.unwrap();
+
+        assert_eq!(status, reqwest::StatusCode::NOT_FOUND);
+        assert_eq!(body["error"]["code"], "not_found");
+        assert_eq!(
+            body["error"]["message"],
+            format!("operation version 99 for {operation_id} was not found")
+        );
+        assert_eq!(
+            body["error"]["context"],
+            json!({
+                "operation_id": operation_id,
+                "version": 99
+            })
+        );
    }

    #[tokio::test(flavor = "multi_thread")]