From 46585fb44523030559d19595656229b38630c3d0 Mon Sep 17 00:00:00 2001
From: "a.tolmachev" <a.tolmachev@tbank.ru>
Date: Sat, 2 May 2026 14:55:33 +0000
Subject: [PATCH] ui: use hidden state for secret kind fields

---
 apps/ui/html/secrets.html | 4 ++--
 apps/ui/js/secrets.js     | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/apps/ui/html/secrets.html b/apps/ui/html/secrets.html
index ba68749..b8a71ba 100644
--- a/apps/ui/html/secrets.html
+++ b/apps/ui/html/secrets.html
@@ -202,7 +202,7 @@
             <input class="field-input" id="secret-string-value" data-testid="secret-value-input" type="text" autocomplete="off">
           </div>
 
-          <div class="field-row" data-kind-field="basic" style="display:none;">
+          <div class="field-row" data-kind-field="basic" hidden>
             <div class="field-group">
               <label class="field-label" data-i18n="secrets.modal.username">Username</label>
               <input class="field-input" id="secret-username" data-testid="secret-username-input" type="text" autocomplete="off">
@@ -213,7 +213,7 @@
             </div>
           </div>
 
-          <div class="field-group" data-kind-field="json" style="display:none;">
+          <div class="field-group" data-kind-field="json" hidden>
             <label class="field-label" data-i18n="secrets.modal.json_payload">JSON payload</label>
             <textarea class="field-textarea code-textarea" id="secret-json-value" data-testid="secret-json-input" rows="8" spellcheck="false"></textarea>
             <div class="field-hint" data-i18n="secrets.modal.json_hint">Useful for generic secret payloads. The value must be valid JSON.</div>
diff --git a/apps/ui/js/secrets.js b/apps/ui/js/secrets.js
index f8e1034..fe1b968 100644
--- a/apps/ui/js/secrets.js
+++ b/apps/ui/js/secrets.js
@@ -166,13 +166,13 @@ function initSecretsPage() {
   function updateKindFields() {
     var kind = modalKind.value;
     document.querySelectorAll('[data-kind-field="string"]').forEach(function (element) {
-      element.style.display = kind === 'token' || kind === 'header' ? '' : 'none';
+      element.hidden = !(kind === 'token' || kind === 'header');
     });
     document.querySelectorAll('[data-kind-field="basic"]').forEach(function (element) {
-      element.style.display = kind === 'username_password' ? '' : 'none';
+      element.hidden = kind !== 'username_password';
     });
     document.querySelectorAll('[data-kind-field="json"]').forEach(function (element) {
-      element.style.display = kind === 'generic' ? '' : 'none';
+      element.hidden = kind !== 'generic';
     });
 
     if (kind === 'token') {