bsodfather/crank
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

core: type streaming session timestamps

Browse Source
This commit is contained in:
a.tolmachev
2026-04-13 05:47:42 +00:00
parent edf318ba67
commit 03cb109b40
10 changed files with 254 additions and 228 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/crank-core/src/stream_session.rs
+50 -36
View File
@@ -1,5 +1,6 @@
use serde::{Deserialize, Serialize};
use serde_json::Value;
use time::OffsetDateTime;
use crate::{
ids::{AgentId, AsyncJobId, OperationId, StreamSessionId, WorkspaceId},
@@ -36,31 +37,34 @@ pub struct StreamSession {
#[serde(skip_serializing_if = "Option::is_none")]
pub cursor: Option<Value>,
pub state: Value,
pub expires_at: String,
#[serde(with = "time::serde::rfc3339")]
pub expires_at: OffsetDateTime,
#[serde(skip_serializing_if = "Option::is_none")]
pub last_poll_at: Option<String>,
pub created_at: String,
#[serde(with = "time::serde::rfc3339::option")]
pub last_poll_at: Option<OffsetDateTime>,
#[serde(with = "time::serde::rfc3339")]
pub created_at: OffsetDateTime,
#[serde(skip_serializing_if = "Option::is_none")]
pub closed_at: Option<String>,
#[serde(with = "time::serde::rfc3339::option")]
pub closed_at: Option<OffsetDateTime>,
}
impl StreamSession {
pub fn is_expired(&self, now: &str) -> bool {
self.expires_at.as_str() <= now
pub fn is_expired(&self, now: OffsetDateTime) -> bool {
self.expires_at <= now
}
pub fn can_poll(&self, now: &str) -> bool {
pub fn can_poll(&self, now: OffsetDateTime) -> bool {
!self.status.is_terminal() && !self.is_expired(now)
}
pub fn mark_polled(&mut self, now: impl Into<String>) {
self.last_poll_at = Some(now.into());
pub fn mark_polled(&mut self, now: OffsetDateTime) {
self.last_poll_at = Some(now);
}
pub fn mark_closed(&mut self, now: impl Into<String>) {
let now = now.into();
pub fn mark_closed(&mut self, now: OffsetDateTime) {
self.status = StreamStatus::Stopped;
self.last_poll_at = Some(now.clone());
self.last_poll_at = Some(now);
self.closed_at = Some(now);
}
}
@@ -99,11 +103,15 @@ pub struct AsyncJobHandle {
#[serde(skip_serializing_if = "Option::is_none")]
pub error: Option<Value>,
#[serde(skip_serializing_if = "Option::is_none")]
pub expires_at: Option<String>,
pub created_at: String,
pub updated_at: String,
#[serde(with = "time::serde::rfc3339::option")]
pub expires_at: Option<OffsetDateTime>,
#[serde(with = "time::serde::rfc3339")]
pub created_at: OffsetDateTime,
#[serde(with = "time::serde::rfc3339")]
pub updated_at: OffsetDateTime,
#[serde(skip_serializing_if = "Option::is_none")]
pub finished_at: Option<String>,
#[serde(with = "time::serde::rfc3339::option")]
pub finished_at: Option<OffsetDateTime>,
}
impl AsyncJobHandle {
@@ -115,20 +123,18 @@ impl AsyncJobHandle {
matches!(self.status, JobStatus::Created | JobStatus::Running)
}
pub fn mark_finished(&mut self, now: impl Into<String>, result: Value) {
let now = now.into();
pub fn mark_finished(&mut self, now: OffsetDateTime, result: Value) {
self.status = JobStatus::Completed;
self.result = Some(result);
self.error = None;
self.updated_at = now.clone();
self.updated_at = now;
self.finished_at = Some(now);
}
pub fn mark_failed(&mut self, now: impl Into<String>, error: Value) {
let now = now.into();
pub fn mark_failed(&mut self, now: OffsetDateTime, error: Value) {
self.status = JobStatus::Failed;
self.error = Some(error);
self.updated_at = now.clone();
self.updated_at = now;
self.finished_at = Some(now);
}
}
@@ -136,6 +142,7 @@ impl AsyncJobHandle {
#[cfg(test)]
mod tests {
use serde_json::json;
use time::{OffsetDateTime, format_description::well_known::Rfc3339};
use super::{AsyncJobHandle, JobStatus, StreamSession, StreamStatus};
use crate::{
@@ -144,6 +151,10 @@ mod tests {
streaming::ExecutionMode,
};
fn timestamp(value: &str) -> OffsetDateTime {
OffsetDateTime::parse(value, &Rfc3339).unwrap()
}
#[test]
fn stream_session_tracks_poll_and_close_transitions() {
let mut session = StreamSession {
@@ -156,20 +167,20 @@ mod tests {
status: StreamStatus::Running,
cursor: None,
state: json!({"cursor":"abc"}),
expires_at: "2026-04-06T12:05:00Z".to_owned(),
expires_at: timestamp("2026-04-06T12:05:00Z"),
last_poll_at: None,
created_at: "2026-04-06T12:00:00Z".to_owned(),
created_at: timestamp("2026-04-06T12:00:00Z"),
closed_at: None,
};
assert!(session.can_poll("2026-04-06T12:01:00Z"));
assert!(session.can_poll(timestamp("2026-04-06T12:01:00Z")));
session.mark_polled("2026-04-06T12:01:00Z");
session.mark_closed("2026-04-06T12:02:00Z");
session.mark_polled(timestamp("2026-04-06T12:01:00Z"));
session.mark_closed(timestamp("2026-04-06T12:02:00Z"));
assert_eq!(session.status, StreamStatus::Stopped);
assert_eq!(session.closed_at.as_deref(), Some("2026-04-06T12:02:00Z"));
assert!(!session.can_poll("2026-04-06T12:03:00Z"));
assert_eq!(session.closed_at, Some(timestamp("2026-04-06T12:02:00Z")));
assert!(!session.can_poll(timestamp("2026-04-06T12:03:00Z")));
}
#[test]
@@ -183,15 +194,15 @@ mod tests {
progress: json!({"percent": 60}),
result: None,
error: None,
expires_at: Some("2026-04-06T12:05:00Z".to_owned()),
created_at: "2026-04-06T12:00:00Z".to_owned(),
updated_at: "2026-04-06T12:00:00Z".to_owned(),
expires_at: Some(timestamp("2026-04-06T12:05:00Z")),
created_at: timestamp("2026-04-06T12:00:00Z"),
updated_at: timestamp("2026-04-06T12:00:00Z"),
finished_at: None,
};
assert!(job.can_cancel());
job.mark_finished("2026-04-06T12:01:00Z", json!({"ok": true}));
job.mark_finished(timestamp("2026-04-06T12:01:00Z"), json!({"ok": true}));
assert!(job.is_finished());
assert_eq!(job.status, JobStatus::Completed);
@@ -200,11 +211,14 @@ mod tests {
failed_job.result = None;
failed_job.finished_at = None;
failed_job.mark_failed("2026-04-06T12:02:00Z", json!({"message": "boom"}));
failed_job.mark_failed(
timestamp("2026-04-06T12:02:00Z"),
json!({"message": "boom"}),
);
assert_eq!(failed_job.status, JobStatus::Failed);
assert_eq!(
failed_job.finished_at.as_deref(),
Some("2026-04-06T12:02:00Z")
failed_job.finished_at,
Some(timestamp("2026-04-06T12:02:00Z"))
);
}
}