From bd4d5efd86ffcc60e217645fd6b405a4d0d1ee13 Mon Sep 17 00:00:00 2001 From: Kevin Stillhammer Date: Thu, 12 Nov 2026 14:45:39 +0100 Subject: [PATCH] Fix workflow tests after ubuntu-latest switch to 26.04 (#1129) ## Summary Fix two workflow issues exposed by the `ubuntu-latest` transition to Ubuntu 26.04, in separate commits: - Use `npx --no-install tsc` in the workflow job dependency check instead of relying on a globally installed TypeScript compiler, matching https://github.com/astral-sh/ruff-action/pull/455. - Disable caching in `test-specific-version`, `test-version-file-version`, and `test-tool-versions-python-version`. These jobs only verify versions or outputs and do not create a dependency cache directory. ## Background The cache key includes the OS version, so the runner transition caused cache misses. Previously restored caches bypassed cache saving and hid the missing-directory problem. On a cold cache, cleanup tried to save a directory that these tests never created. Disabling caching makes these non-cache tests independent of existing cache entries; dedicated cache tests remain unchanged. ## Validation - `npm ci --ignore-scripts` and `npm run all` using npm 11.10.0 after the compiler fix (176 tests passed) - Workflow TypeScript compilation and job dependency check - `actionlint` and `uvx zizmor .github/workflows/test.yml` passed after both changes - `git diff --check` Refs: pi-session 01a1cfe6-d342-70b6-a474-504b84877d9e --- .github/workflows/test.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a078d8f..806b616 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -40,7 +40,7 @@ jobs: npm run all - name: Check all jobs are in all-tests-passed.needs run: | - tsc -p tsconfig.json + npx --no-install tsc -p tsconfig.json node check-all-tests-passed-needs.js working-directory: .github/scripts - name: Make sure no changes from linters are detected @@ -136,6 +136,7 @@ jobs: id: setup-uv uses: $/ with: + enable-cache: false version: ${{ matrix.input.version-input }} resolution-strategy: ${{ matrix.input.resolution-strategy || 'highest' }} - name: Correct version gets installed @@ -227,6 +228,7 @@ jobs: - name: Install version from ${{ matrix.input.version-file }} uses: $/ with: + enable-cache: false version-file: ${{ matrix.input.version-file }} - name: Correct version gets installed run: | @@ -245,6 +247,7 @@ jobs: id: setup-uv uses: $/ with: + enable-cache: false version-file: "__tests__/fixtures/.tool-versions" - name: Verify Python version from .tool-versions run: |